Add spans via metadata to IR. #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two types are supported now: - a `filepath` referencing a Sway file. - a `span` which references a `filepath` and has start and end indices.
When compiling from AST to IR they are generated, and when compiling from IR to ASM they are referenced.
otrho
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 95% to where I'd like it to be. There's #795 and #801 which will change how we work with spans, but they're semi-blocked by the new parser (I don't want to have to do it twice). If we take the source out of
Spanas #795 suggests then the metadata can be simplified.There are a few changes in the IR -> ASM here which are doing a bunch of calculations for memory allocations for aggregates which I'd like to see simplified by addressing #738.
Closes #718.