Skip to content

Conversation

@Dentosal
Copy link
Member

@Dentosal Dentosal commented Apr 14, 2025

Description

This PR contains an initial implementtion of subroutine calls using the in-progress jump-and-link instruction JAL. It substantially reduces the function call overhead: the old code used 4 instructions per call, while the new version uses 1-3 depending on the distance to the called function.

Future optimizations

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Dentosal Dentosal self-assigned this Apr 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 23, 2025

CodSpeed Performance Report

Merging #7085 will not alter performance

Comparing dento/new-fncall (c4061ed) with master (8b75246)

Summary

✅ 25 untouched benchmarks

@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 03:19 — with GitHub Actions Inactive
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 03:41 — with GitHub Actions Inactive
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 04:35 — with GitHub Actions Inactive
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 05:55 — with GitHub Actions Inactive
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 06:44 — with GitHub Actions Inactive
@Dentosal Dentosal marked this pull request as ready for review July 1, 2025 07:28
@Dentosal Dentosal requested review from a team as code owners July 1, 2025 07:28
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 07:28 — with GitHub Actions Inactive
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 1, 2025 18:29 — with GitHub Actions Inactive
@Dentosal Dentosal requested review from a team and xunilrj July 3, 2025 06:46
@Dentosal Dentosal temporarily deployed to fuel-sway-bot July 7, 2025 13:34 — with GitHub Actions Inactive
@Dentosal Dentosal requested a review from a team July 7, 2025 13:34
@IGI-111 IGI-111 enabled auto-merge (squash) July 9, 2025 06:39
@IGI-111 IGI-111 temporarily deployed to fuel-sway-bot July 9, 2025 06:39 — with GitHub Actions Inactive
@IGI-111 IGI-111 merged commit 74092cb into master Jul 12, 2025
40 checks passed
@IGI-111 IGI-111 deleted the dento/new-fncall branch July 12, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants