Extend #[deprecated] support
#6944
Open
+490
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
had a problem deploying
to
fuel-sway-bot
GitHub Actions
Error
IGI-111
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #6944 will not alter performanceComparing Summary
|
IGI-111
force-pushed
the
IGI-111/deprecated
branch
from
9b557d5 to
5be38d1
Compare
IGI-111
had a problem deploying
to
fuel-sway-bot
GitHub Actions
Error
Add support for the `#[deprecated]` attribute to functions, enums, struct items, enum variants and propagate deprecation check exhaustively throughout expressions variants. Partially addresses #6942. Support for deprecating traits, abis and the methods thereof in their definitions is still missing, as well as scrutinees and storage fields.
IGI-111
force-pushed
the
IGI-111/deprecated
branch
from
5be38d1 to
698fc62
Compare
IGI-111
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
IGI-111
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
IGI-111
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
ironcev
requested changes
Feb 24, 2025
| | | ||
| 219 | #[deprecated(note = "std::ecr has been replaced by std::crypto, and is no longer maintained")] | ||
| 220 | pub fn ec_recover_address(signature: B512, msg_hash: b256) -> Result<Address, EcRecoverError> { | ||
| 221 | let pub_key_result = ec_recover(signature, msg_hash); |
There was a problem hiding this comment.
This means that std compiles with warnings. And it is essentially a deprecated function calling another deprecated function from the same module.
Adding #[allow(deprecated)] on all those functions next to the #[deprecated] will remove this issue. They will still be deprecated for all other usages, but will allow calling other deprecated functions from the same module.
There was a problem hiding this comment.
I didn't dig into it but if those are indeed deprecated functions calling each other I agree. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
#[deprecated]attribute to functions, enums, struct items, enum variants and propagate deprecation check exhaustively throughout expressions variants.Partially addresses #6942.
Support for deprecating traits, abis and the methods thereof in their definitions is still missing, as well as scrutinees and storage fields.
Checklist
Breaking*orNew Featurelabels where relevant.