Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate DWARF debug symbols in debug builds #6863

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Jan 28, 2025

Description

DWARF debug symbols are now automatically generated and saved as debug_symbols.obj in the output directory when using debug builds. This enables better debugging support out of the box in development without requiring the -g flag. The -g flag is still supported for specifying custom debug symbol output paths or generating debug symbols in other build profiles.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner January 28, 2025 00:43
@JoshuaBatty JoshuaBatty self-assigned this Jan 28, 2025
@JoshuaBatty JoshuaBatty added forc-pkg Everything related to the `forc-pkg` crate. compiler:debug-info Debug Info support in the compiler labels Jan 28, 2025
alfiedotwtf
alfiedotwtf previously approved these changes Jan 28, 2025
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #6863 will not alter performance

Comparing josh/save_dwarf (9dc47b5) with master (b03c76e)

Summary

✅ 22 untouched benchmarks

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner January 28, 2025 01:48
@JoshuaBatty JoshuaBatty requested review from alfiedotwtf and a team January 28, 2025 02:01
Copy link
Contributor

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoshuaBatty JoshuaBatty merged commit 1bdd2ce into master Jan 28, 2025
41 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/save_dwarf branch January 28, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:debug-info Debug Info support in the compiler forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants