-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add splice method to Bytes #6823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like the addition of splice, but I think we should match Rust's Vec impl https://doc.rust-lang.org/std/vec/struct.Vec.html#method.splice by taking a second optional param replace_with |
xunilrj
reviewed
Jan 13, 2025
jjcnn
requested changes
Jan 14, 2025
test/src/in_language_tests/test_programs/bytes_inline_tests/src/splice.sw
Show resolved
Hide resolved
jjcnn
previously approved these changes
Jan 17, 2025
K1-R1
previously approved these changes
Jan 21, 2025
…abs/sway into swaystar123/bytes-splicing
K1-R1
approved these changes
Jan 21, 2025
jjcnn
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a splice method to bytes that lets you select start and end indices, and returns the range of bytes, removing them from the original bytes.
Checklist
Breaking*
orNew Feature
labels where relevant.