Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instances of multiple impl blocks #6822

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

SwayStar123
Copy link
Collaborator

Description

Previously due to issue #1548 it was not possible to use a method defined in an impl block in another method defined in the same impl block, that issue is now fixed.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Jan 9, 2025
@SwayStar123 SwayStar123 added lib: std Standard library code quality lib: core Core library labels Jan 9, 2025
@SwayStar123 SwayStar123 marked this pull request as ready for review January 9, 2025 08:07
@SwayStar123 SwayStar123 requested review from a team as code owners January 9, 2025 08:07
@SwayStar123 SwayStar123 merged commit 561007d into master Jan 9, 2025
39 checks passed
@SwayStar123 SwayStar123 deleted the swaystar123/remove-multiple-impl-block branch January 9, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality lib: core Core library lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants