Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing of storage_domains to language and SDK tests #6809

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Jan 6, 2025

Description

This PR extends the language and SDK tests on CI to also run with the storage_domains experimental feature turned on.

This is a part of our general testing strategy for experimental features. For E2E tests, we test only a handful of selected tests with the target experimental feature turned on. For language and SDK tests, we want to run all of the tests for every experimental feature.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev requested a review from a team as a code owner January 6, 2025 11:23
@ironcev ironcev self-assigned this Jan 6, 2025
@ironcev ironcev requested review from a team January 6, 2025 11:23
@ironcev ironcev added the ci label Jan 6, 2025
@ironcev ironcev merged commit 76c060b into master Jan 7, 2025
39 checks passed
@ironcev ironcev deleted the ironcev/add-experimental-storage-domain-to-language-and-sdk-tests branch January 7, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants