Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate lexical scopes with their respective declarations. #6780

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Dec 9, 2024

This adds a mapping from a lexical scope to the declaration that lexically corresponds to it.

This is necessary for some upcoming collection context PR.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

This adds a mapping from a lexical scope to the declaration that
lexically corresponds to it.

This is necessary for some upcoming collection context PR.
@tritao tritao added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: collection Everything to do with graph collection, type collection, and the collection context. labels Dec 9, 2024
@tritao tritao self-assigned this Dec 9, 2024
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #6780 will not alter performance

Comparing tritao:scope-associated-decl (deaca7a) with master (ff8291a)

Summary

✅ 22 untouched benchmarks

@tritao tritao marked this pull request as ready for review December 9, 2024 19:38
@tritao tritao requested a review from a team as a code owner December 9, 2024 19:38
@IGI-111 IGI-111 requested a review from a team December 11, 2024 01:57
@JoshuaBatty JoshuaBatty merged commit 36849be into FuelLabs:master Dec 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: collection Everything to do with graph collection, type collection, and the collection context. compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants