Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes qualified call path without as trait. #6764

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fixes qualified call path without as trait. #6764

merged 2 commits into from
Nov 29, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Nov 28, 2024

Description

The parser no longer parses qualified call paths without the as token and trait.

This invalidates code that was previously accepted such as: let x: <u8>::S::<u8> = S::<u8>{x: 8};

Fixes #6389

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added compiler: parser Everything to do with the parser audit-report Related to the audit report labels Nov 28, 2024
@esdrubal esdrubal self-assigned this Nov 28, 2024
The parser no longer parses qualified call path without the `as` token and trait.

This invalidates code that was previously accepted such as:
`let x: <u8>::S::<u8> = S::<u8>{x: 8};``

Fixes #6389
@esdrubal esdrubal marked this pull request as ready for review November 29, 2024 12:21
@esdrubal esdrubal requested review from a team as code owners November 29, 2024 12:21
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #6764 will degrade performances by 70.88%

Comparing esdrubal/6389 (d3322b2) with master (33d3674)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master esdrubal/6389 Change
document_symbol 5.5 ms 18.9 ms -70.88%

@tritao tritao merged commit 6d9065b into master Nov 29, 2024
41 checks passed
@tritao tritao deleted the esdrubal/6389 branch November 29, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-report Related to the audit report compiler: parser Everything to do with the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing Generics
3 participants