Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on use of self intead of Self in return type #6763

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Nov 27, 2024

Description

With this PR we no longer support using self instead of Self when referring to the Self Type.

Fixes #6396

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

With this PR we no longer support using `self` instead of `Self` when refering to the Self Type.

Fixes #6396
@esdrubal esdrubal added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen audit-report Related to the audit report labels Nov 27, 2024
@esdrubal esdrubal self-assigned this Nov 27, 2024
Copy link

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #6763 will not alter performance

Comparing esdrubal/6396 (56920a6) with master (bcd15c3)

Summary

✅ 22 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review November 27, 2024 13:09
@esdrubal esdrubal requested review from a team as code owners November 27, 2024 13:09
@tritao tritao merged commit a02e8ea into master Nov 28, 2024
41 checks passed
@tritao tritao deleted the esdrubal/6396 branch November 28, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-report Related to the audit report compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Use of self
3 participants