Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve asm copy propagation for MOVE instruction #6641

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 15, 2024

Description

This PR improve value propagation optimization in two ways:

1 - First, when the optimizer knows that both source and destination registers of the MOVE instruct have the same value and version; it will remove the instruction as it is useless;
2 - Otherwise, we propagate the value saying that destination now have the same value and version of the source register for other optimizations.

Gains on real contracts

Contract A From 143.672 KB to 142.76 KB : 912 bytes or 0.6%
Contract B from 26.488 KB to 26.264 KB: 224 bytes or 0.8%
Contract C from 22.176 KB to 22.096 KB: 80 bytes or or 0.3%

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #6641 will not alter performance

Comparing xunilrj/cpy-propagation-move (9566700) with master (64d1c6e)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj force-pushed the xunilrj/cpy-propagation-move branch from 63b0bfa to 80d5a52 Compare November 15, 2024 11:04
vaivaswatha
vaivaswatha previously approved these changes Nov 20, 2024
@xunilrj xunilrj marked this pull request as ready for review November 23, 2024 19:03
@xunilrj xunilrj requested review from a team as code owners November 23, 2024 19:03
@xunilrj xunilrj self-assigned this Nov 23, 2024
@vaivaswatha
Copy link
Contributor

Do you think we can have numbers before and after this change? maybe for just one or two important contracts if not our testsuite.

@xunilrj xunilrj requested a review from vaivaswatha November 25, 2024 12:04
@IGI-111 IGI-111 merged commit bcd15c3 into master Nov 25, 2024
41 checks passed
@IGI-111 IGI-111 deleted the xunilrj/cpy-propagation-move branch November 25, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants