Skip to content

Rename visit_expr to expr_leaf_spans #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2022
Merged

Rename visit_expr to expr_leaf_spans #2914

merged 1 commit into from
Oct 1, 2022

Conversation

@eureka-cpu
Copy link
Contributor

@eureka-cpu eureka-cpu commented Oct 1, 2022

Closes #2500

@eureka-cpu eureka-cpu added this to the swayfmt milestone Oct 1, 2022
@eureka-cpu eureka-cpu self-assigned this Oct 1, 2022
kayagokalp
kayagokalp approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@eureka-cpu eureka-cpu merged commit 38efff4 into master Oct 1, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/2500 branch October 1, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@kayagokalp kayagokalp kayagokalp approved these changes

@spiral-ladder spiral-ladder Awaiting requested review from spiral-ladder

Assignees

@eureka-cpu eureka-cpu

Labels

code quality forc formatter

Projects

None yet

Milestone

swayfmt

Development

Successfully merging this pull request may close these issues.

Rename visit_expr() to expr_leaf_spans() in sfv2

4 participants

@eureka-cpu @JoshuaBatty @kayagokalp