feat: sign forc-deploy transactions #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just adding a note (previously discussed on slack with @kayagokalp): I think it might be best if we first wait to update #2622 tracks the |
|
Ahh it looks like #2482 is doing the heavy-work of updating to the latest |
2 tasks
kayagokalp
changed the title
mitchmindtree
previously approved these changes
Sep 1, 2022
sezna
previously approved these changes
Sep 1, 2022
sezna
approved these changes
Sep 1, 2022
mitchmindtree
approved these changes
Sep 1, 2022
mitchmindtree
added a commit
that referenced
this pull request
Sep 2, 2022
…formatting fixes (#2698) * refactor: forc-deploy requires wallet address and accepts signature (#2629) * Add the `CopyTypes` trait to `DeclarationId` (#2682) Co-authored-by: Toby Hutton <[email protected]> * fix: Unformatted comment spans add extra newline (#2692) * newline handler checks for existing newlines before inserting new ones * stability test added * newline-comment handler interaction test added * review suggestion * feat: add basic comment context formatting (#2697) * feat: add comment context formatting * test: enhance newline-comment handler interaction test * Apply suggestions from code review Co-authored-by: mitchmindtree <[email protected]> Co-authored-by: mitchmindtree <[email protected]> * Update `examples/` for recent swayfmt-v2 patches Co-authored-by: Kaya Gökalp <[email protected]> Co-authored-by: Emily Herbert <[email protected]> Co-authored-by: Toby Hutton <[email protected]>
eureka-cpu
added a commit
that referenced
this pull request
Sep 2, 2022
* update plugin and swayfmt toml, remove old formatter * update config to formatter for consistency * wip fix lsp formatting * more merge conflicts * update dependencies to 22.1 * remove files that made it back in from merge * comment out function in LSP that uses formatter * format examples and remove debug printlns * Merge #2669 (swayfmt replacement PR) with `master` including newline formatting fixes (#2698) * refactor: forc-deploy requires wallet address and accepts signature (#2629) * Add the `CopyTypes` trait to `DeclarationId` (#2682) Co-authored-by: Toby Hutton <[email protected]> * fix: Unformatted comment spans add extra newline (#2692) * newline handler checks for existing newlines before inserting new ones * stability test added * newline-comment handler interaction test added * review suggestion * feat: add basic comment context formatting (#2697) * feat: add comment context formatting * test: enhance newline-comment handler interaction test * Apply suggestions from code review Co-authored-by: mitchmindtree <[email protected]> Co-authored-by: mitchmindtree <[email protected]> * Update `examples/` for recent swayfmt-v2 patches Co-authored-by: Kaya Gökalp <[email protected]> Co-authored-by: Emily Herbert <[email protected]> Co-authored-by: Toby Hutton <[email protected]> * change name to swayfmt, kashira * add swayfmt file * sort toml dependencies * fix excess newlines in format_context * test on examples Co-authored-by: mitchmindtree <[email protected]> Co-authored-by: Kaya Gökalp <[email protected]> Co-authored-by: Emily Herbert <[email protected]> Co-authored-by: Toby Hutton <[email protected]> Co-authored-by: Mohammad Fawaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
closes #2623.
Blocked until FuelLabs/fuels-rs#540 is merged and released. While testing I pointed to a local instance of the SDK,most of the diff is actually coming from the lock file.TODO