Changes .clone().into_inner() to .get() in sfv2
#2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eureka-cpu
added
forc
code quality
formatter
breaking
eureka-cpu
requested review from
adlerjohn,
kayagokalp,
mitchmindtree and
otrho
Contributor
|
It'll be about |
Contributor
Author
I appreciate the swift reply <3 |
eureka-cpu
removed
the
breaking
kayagokalp
approved these changes
Aug 10, 2022
Member
kayagokalp
left a comment
kayagokalp
left a comment
There was a problem hiding this comment.
looks perfect and a lot cleaner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into a problem that I'm assuming came from this, which is that clippy is complaining about IR using an unstable feature. cc @otrho any idea what I can do to fix it?JK, somehow clippy is passing here but not on my machine...
Rust update fixed it
Closes #2499