Skip to content

Adds impl formatting to sfv2 #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 1, 2022
Merged

Adds impl formatting to sfv2 #2403

merged 8 commits into from
Aug 1, 2022

Conversation

@eureka-cpu
Copy link
Contributor

@eureka-cpu eureka-cpu commented Jul 28, 2022 •
edited
Loading

Closes #2068

  • Add better test

@eureka-cpu eureka-cpu added enhancement New feature or request forc formatter labels Jul 28, 2022
@eureka-cpu eureka-cpu added this to the swayfmt-v2 milestone Jul 28, 2022
@eureka-cpu eureka-cpu requested a review from kayagokalp July 28, 2022 16:05
@eureka-cpu eureka-cpu self-assigned this Jul 28, 2022
@eureka-cpu eureka-cpu mentioned this pull request Jul 28, 2022
Closed
sezna
sezna reviewed Jul 30, 2022
View reviewed changes
sezna
sezna suggested changes Jul 30, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC until testing question is resolved

@eureka-cpu eureka-cpu requested a review from sezna July 30, 2022 01:35
sezna
sezna previously approved these changes Jul 30, 2022
View reviewed changes
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add some more tests here, but this is good for now. Maybe in the future we can worry about a larger formatter test suite like the sway compiler one.

@kayagokalp
Copy link
Member

kayagokalp commented Jul 31, 2022

this looks good to me but there seem to be some conflicts. I will happily approve once those are resolved 👍

@eureka-cpu eureka-cpu requested a review from sezna August 1, 2022 19:22
sezna
sezna previously approved these changes Aug 1, 2022
View reviewed changes
@eureka-cpu eureka-cpu requested a review from sezna August 1, 2022 22:05
@eureka-cpu eureka-cpu enabled auto-merge (squash) August 1, 2022 22:48
@eureka-cpu eureka-cpu merged commit b56f4dc into master Aug 1, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/item-impl branch August 1, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@mitchmindtree mitchmindtree Awaiting requested review from mitchmindtree

@JoshuaBatty JoshuaBatty Awaiting requested review from JoshuaBatty

@mohammadfawaz mohammadfawaz Awaiting requested review from mohammadfawaz

+1 more reviewer

@sezna sezna sezna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@eureka-cpu eureka-cpu

Labels

enhancement New feature or request forc formatter

Projects

None yet

Milestone

swayfmt

Development

Successfully merging this pull request may close these issues.

Add impl formatting to sway-fmt-v2

4 participants

@eureka-cpu @kayagokalp @sezna