Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RETD instead of RET for data larger than one word. #238

Merged
merged 7 commits into from
Sep 21, 2021
Merged

Use RETD instead of RET for data larger than one word. #238

merged 7 commits into from
Sep 21, 2021

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Sep 18, 2021 •
edited
Loading

Closes #46

  1. Introduces the RETD opcode to our asm language.
  2. Uses RETD for script main function returns if the data is larger than a word.
  3. Tests that the returned values from scripts are consistent (although they are hashed/masked)

@sezna
Copy link
Contributor Author

sezna commented Sep 18, 2021 •
edited
Loading

I am unsure if RETD is behaving as it should, I'm going to ask for some eyes on this with me on Monday.

Edit: it is behaving as it should, but I was not behaving as I should.

@sezna sezna mentioned this pull request Sep 20, 2021
Closed
@sezna sezna self-assigned this Sep 20, 2021
@sezna sezna added the compiler General compiler. Should eventually become more specific as the issue is triaged label Sep 20, 2021
@sezna sezna marked this pull request as ready for review September 21, 2021 00:14
@sezna sezna changed the title Draft: Use RETD instead of RET for data larger than one word. Use RETD instead of RET for data larger than one word. Sep 21, 2021
otrho
otrho previously approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@otrho otrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be handy for implementing the b256 stdlib funcs and tests. 👍

@sezna sezna merged commit 446941a into master Sep 21, 2021
@sezna sezna deleted the sezna/retd branch September 21, 2021 14:22
@sezna sezna mentioned this pull request Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otrho otrho otrho approved these changes

@emilyaherbert emilyaherbert Awaiting requested review from emilyaherbert

@vlopes11 vlopes11 Awaiting requested review from vlopes11

Assignees

@sezna sezna

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RETD for return values larger than a word.
2 participants
@sezna @otrho