-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the TypeBinding
type
#2195
Conversation
…-1143-3/disallow-unconstrained-type-parameters
…-1898-2/semantic-type-constraints
…-1143-3/disallow-unconstrained-type-parameters
…-1898-2/semantic-type-constraints
…-1143-3/disallow-unconstrained-type-parameters
…-1898-2/semantic-type-constraints
…-1143-3/disallow-unconstrained-type-parameters
…tic-type-constraints
…constrained-type-parameters' into emilyaherbert-1898-2/semantic-type-constraints
…emilyaherbert-1898-2/semantic-type-constraints
…2/semantic-type-constraints
…3/disallow-unconstrained-type-parameters
…ters' into emilyaherbert-1898-2/semantic-type-constraints
…mantic-type-constraints
…heck' into emilyaherbert/use-callpath-as-wrapper
…apper' into emilyaherbert/use-type-binding
…t/use-callpath-as-wrapper
…rt/use-type-binding
…t/use-callpath-as-wrapper
…rt/use-type-binding
…t/use-callpath-as-wrapper
…rt/use-type-binding
…t/use-callpath-as-wrapper
…allpath-as-wrapper
…rt/use-type-binding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will admit I've been avoiding this review since it's big and I don't fully understand exactly what is going on, but it still looks good to me.
I'd say about 50% of the green additions are from introducing a new test, hopefully that helps calm your feelings 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new syntax looks more correct and reasonable. The rest of the PR looks good! And the testing seems quite extensive.
This PR introduces the
TypeBinding
type, which represents the application of turbofish upon some LHS declaration or type, which will bind the type arguments of the turbofish to the type parameters in the LHS. This allows us to do things like:previously, we were unable to have different generics between the data type and the internal methods.
CallPath
into a wrapper type #2191