-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a generic log
function
#1572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: sway-lib-std/src/assert.sw
I see that removing module |
mohammadfawaz
added
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
May 17, 2022
Ahh. I should really add more tests, there's only one existing atm :) |
After #1573 lands I'll merge |
sezna
previously approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Conflicts: examples/hashing/src/main.sw
otrho
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
May cause existing user code to break. Requires a minor or major release.
enhancement
New feature or request
lib: std
Standard library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
__is_reference_type
and__size_of
intrinsics to use eitherlog
orlogd
internally.log_u64
,log_b256
, etclogging
module and reorgs the lib a little to bypass this blocker: Explicit ordering ofdep
statements is required to resolve dependencies. #409chain
module to prevent breaking everything that useschain/auth
(this feels a bit hacky... probably better to keep it clean, remove the chain mod and force users to update the path.)close #1358
close #823