Add an is_reference_type::<T>() builtin.
#1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otrho
added
enhancement
This was referenced Mar 31, 2022
Merged
otrho
force-pushed
the
otrho/1119_is_reference_type
branch
from
0cc886f
to
547ec0c
Compare
Returns false for copy types (unit, bool, byte, uint), true otherwise. This is a temporary measure to assist in getting the stdlib richer now, i.e., to make decisions regarding ASM block instructions based on generic types, but isn't reliable once we have optimisations which could invalidate compile time assertions like this. A 'reference type' may not always be used by reference if optimisations allow a value to be passed by value. `is_reference_type::<T>()` closely resembles `size_of::<T>()` in both syntax and semantics and so I've combined them into a builtin 'type property' expression and split the `size_of_value(expr)` expression into its own thing.
otrho
force-pushed
the
otrho/1119_is_reference_type
branch
from
547ec0c
to
ab6b7e9
Compare
adlerjohn
approved these changes
Apr 1, 2022
|
Unit is definitely a copy type at the moment (the test is passing) and should stay that way. I've updated the code to reflect this everywhere, like in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns false for copy types (unit, bool, byte, uint), true otherwise.
This is a temporary measure to assist in getting the stdlib richer now, i.e., to make decisions regarding ASM block instructions based on generic types, but isn't reliable once we have optimisations which could invalidate compile time assertions like this. A 'reference type' may not always be used by reference if optimisations allow a value to be passed by value.
is_reference_type::<T>()closely resemblessize_of::<T>()in both syntax and semantics and so I've combined them into a builtin 'type property' expression and split thesize_of_value(expr)expressioninto its own thing.
Closes #1119.
Closes #1120.