Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntoIterator and support to fallback to calling iterator.into_iter() on failure #5568

Open
esdrubal opened this issue Feb 7, 2024 · 0 comments
Open

Add IntoIterator and support to fallback to calling iterator.into_iter() on failure #5568

esdrubal opened this issue Feb 7, 2024 · 0 comments
Assignees
@tritao @esdrubal
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen team:compiler Compiler Team

Comments

@esdrubal
Copy link
Contributor

esdrubal commented Feb 7, 2024

Right now we need to call iter() on a vector to use a for loop.

script;

fn main()  {
    let mut vector = Vec::new();
    for _n in vector.iter() {
    }
}

The proposed change in this issue is to desugar the for loop into two expressions the default one we already have and another one that tries to automatically call the fully qualified path .into_iter() method on the iterator part of the for. When the first desugared expression fails to compile we would try to use the second one.

An example of this on rust is https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=6bcab16907b3a79b239249ba98557afe
@esdrubal esdrubal added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Feb 7, 2024
@esdrubal esdrubal self-assigned this Feb 7, 2024
This was referenced Feb 7, 2024
Merged
Open
@esdrubal esdrubal changed the title Add IntoIterator and support to fallback to calling `iterator.into_iter()' on failure Add IntoIterator and support to fallback to calling iterator.into_iter() on failure Feb 7, 2024
esdrubal added a commit that referenced this issue Feb 8, 2024
@esdrubal
Implements Iterator trait and for loops. (#5557)
80be608 
## Description

This implements an Iterator trait in std-lib, and adds iter() to Vec.
This also adds parsing and desugaring of for loops.

```
    for pattern in iterator {
        code_block
    }
```
 is desugared into:
```
    let mut iterable = iterator;
    while true {
        let value_opt = iterable.next();
        if value_opt.is_none() {
             break;
        }
        let value = value_opt.unwrap();
        code_block
    }
```

This also adds for loops documentation to the control flow docs.

We still have to fix this issues:
 -  #5567
 -  #5568
 -  #5570
 -  #5571

Closes #145

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
sdankel pushed a commit that referenced this issue Feb 8, 2024
@esdrubal @sdankel
Implements Iterator trait and for loops. (#5557)
2f605d5 
## Description

This implements an Iterator trait in std-lib, and adds iter() to Vec.
This also adds parsing and desugaring of for loops.

```
    for pattern in iterator {
        code_block
    }
```
 is desugared into:
```
    let mut iterable = iterator;
    while true {
        let value_opt = iterable.next();
        if value_opt.is_none() {
             break;
        }
        let value = value_opt.unwrap();
        code_block
    }
```

This also adds for loops documentation to the control flow docs.

We still have to fix this issues:
 -  #5567
 -  #5568
 -  #5570
 -  #5571

Closes #145

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
@IGI-111 IGI-111 mentioned this issue Apr 23, 2024
Open
36 tasks
@IGI-111 IGI-111 added the team:compiler Compiler Team label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritao tritao

@esdrubal esdrubal

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen team:compiler Compiler Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tritao @esdrubal @IGI-111