-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
bugSomething isn't workingSomething isn't workingcompiler: parserEverything to do with the parserEverything to do with the parsergood first issueGood for newcomersGood for newcomersteam:compilerCompiler TeamCompiler Team
Description
Comment lexing works perfectly while the comments are single-line comments like the following:
// This is a comment
but if the comments are in the form of multiline we are missing the trailing / in the comment's span. So for this example:
/*This is a comment*/
.span().as_str() returns /*This is a comment*
I feel like this shouldn't be hard to tackle so added the "good first issue" label but I did not touch lexer enough to be sure about that so please remove it if that is not the case 🙌 .
Depending on the discussion at #2311 (comment) I can either fix it in #2311 or take a look at this after that is merged.
Related to #2311 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcompiler: parserEverything to do with the parserEverything to do with the parsergood first issueGood for newcomersGood for newcomersteam:compilerCompiler TeamCompiler Team
Type
Projects
Status
Done