Update `Punctuated` to handle trailing punctuation

[eureka-cpu]

Once #2110 gets merged, we will have handling of punctuated pairs, but it doesn't yet handle trailing punctuation well. Something like:

contract;

abi StorageMapExample {
    #[storage(write,)]fn insert_into_map1(key: u64, value: u64);
}

gets formatted to:

contract;

abi StorageMapExample {
    #[storage(write, )] // <-- notice the comma and trailing space
    fn insert_into_map1(key: u64, value: u64);
}

The same is true for multiple args with a trailing comma like:

contract;

abi StorageMapExample {
    #[storage(write, read, )]
    fn insert_into_map1(key: u64, value: u64);
}

[eureka-cpu]

I think a good approach to this would be to have the option for trailing commas be handled in Punctuation with a match expression like:

if formatter.config.lists.trailing_commas = true {
    match value_pairs.into_inner() {
        Attr(Ident, CommaToken) => { /* formatting... */ },
        ... => { /* formatting... */ },
        _ => // normal formatting logic
    }
}

Edit: This will require some digging into lists

[eureka-cpu]

#2338 closed this