`sway-parse` only lexes comments, and doesn't give spans

[eureka-cpu]

Blocker for handling comments in swayfmt v2

At some point we will need to find a way to handle comments so that we get types for comment & multiline comment as well as the spans. We'll need this if we want to have reformatting features for comments like: wrap comments or for reformatting multiline comments to normal comments.

[mohammadfawaz]

Hmmm I don't remember having trouble with the new parser and comments. Can you show specifically what's not working?

[eureka-cpu]

Hmmm I don't remember having trouble with the new parser and comments. Can you show specifically what's not working?

It's not that it's not working per-say, rather that it's just not there at all.
In order to reformat comments, we need handling of comments from the parser. The only thing I can find is an error UnclosedMultilineComment, which is a variant of token::LexErrorKind.

[eureka-cpu]

To be specific we would just need the type of comment, multiline or not, and the span.

[eureka-cpu]

NVM, found the function token::lex() that handling comments, but it's handling comments in a similar way that the current formatter handles them. I was under the impression we would get comment handling as items from the ast.

[eureka-cpu]

Closing this since my initial statement was incorrect, and will bikeshed w/ tooling on how to proceed when the time comes. Thanks @mohammadfawaz !

[eureka-cpu]

@sezna @mitchmindtree for more insight if you can provide it!