test: CEI pattern violation in intrinsic arguments

test/src/e2e_vm_tests/test_programs/should_pass/static_analysis/cei_pattern_violation_in_intrinsic_call/Forc.lock

@@ -0,0 +1,13 @@
+[[package]]
+name = 'cei_pattern_violation_in_intrinsic_call'
+source = 'member'
+dependencies = ['std']
+
+[[package]]
+name = 'core'
+source = 'path+from-root-8075CAB8EEC6376F'
+
+[[package]]
+name = 'std'
+source = 'path+from-root-8075CAB8EEC6376F'
+dependencies = ['core']

test/src/e2e_vm_tests/test_programs/should_pass/static_analysis/cei_pattern_violation_in_intrinsic_call/Forc.toml

@@ -0,0 +1,8 @@
+[project]
+name = "cei_pattern_violation_in_intrinsic_call"
+authors = ["Fuel Labs <[email protected]>"]
+entry = "main.sw"
+license = "Apache-2.0"
+
+[dependencies]
+std = { path = "../../../../../../../sway-lib-std" }

test/src/e2e_vm_tests/test_programs/should_pass/static_analysis/cei_pattern_violation_in_intrinsic_call/src/main.sw

@@ -0,0 +1,29 @@
+contract;
+
+use std::storage::store;
+
+abi TestAbi {
+  #[storage(write)]
+  fn deposit(amount: u64);
+}
+
+impl TestAbi for Contract {
+  #[storage(write)]
+  fn deposit(amount: u64) {
+    // 1st intrinsic argument is a code block with interaction
+    // 2nd intrinsic argument is a code block with effect
+    __add(
+      {
+        // interaction
+        abi(TestAbi, 0x3dba0a4455b598b7655a7fb430883d96c9527ef275b49739e7b0ad12f8280eae).deposit(amount);
+        21
+      },
+      {
+        // effect -- therefore violation of CEI where effect should go before interaction
+        // (assuming left-to-right function argument evaluation)
+        store(0x3dba0a4455b598b7655a7fb430883d96c9527ef275b49739e7b0ad12f8280eae, ());
+        21
+      }
+    );
+  }
+}

test/src/e2e_vm_tests/test_programs/should_pass/static_analysis/cei_pattern_violation_in_intrinsic_call/test.toml

@@ -0,0 +1,3 @@
+category = "compile"
+
+# check: $()Storage modification after external contract interaction in function or method "deposit". Consider making all storage writes before calling another contract