Chores #274
Merged
Chores #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuinnLee
approved these changes
May 15, 2022
luizstacio
requested changes
May 15, 2022
| @@ -63,7 +63,7 @@ export class TransactionScriptCoder extends Coder { | |||
| parts.push(new NumberCoder('gasPrice', 'u64').encode(value.gasPrice)); | |||
| parts.push(new NumberCoder('gasLimit', 'u64').encode(value.gasLimit)); | |||
| parts.push(new NumberCoder('bytePrice', 'u64').encode(value.bytePrice)); | |||
| parts.push(new NumberCoder('maturity', 'u32').encode(value.maturity)); | |||
| parts.push(new NumberCoder('maturity', 'u64').encode(value.maturity)); | |||
There was a problem hiding this comment.
I think we should keep it as spec even if the decoder results in the same 8 bytes. https://github.com/FuelLabs/fuel-specs/blob/master/specs/protocol/tx_format.md
There was a problem hiding this comment.
Hmm. I thought we changed maturity to u64. There are other places where we type maturity u64 so I've opened an issue to fix this completely: #275
Let's keep this change though so at least all maturities are u64 instead of only one being u32.
There was a problem hiding this comment.
Actually, this fixes a bug and we need it because the JS type is bigint and this returns number.
luizstacio
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: repo scripts
Days since someone got rekt by not having
set -euo pipefail: 0We didn't have
set -euo pipefailin our .sh files so we weren't noticing one of the contracts was failing to build. (The reason was the forgottenlib-stdandlib-coredependencies.) I've fixed the issue and also addedset -euo pipefailto all of our .sh files.fix: coder type
maturitywas previously typedu32and was later changed tou64. We forgot some and didn't notice because we encode them the same.chore: replace hardcoded script with actual Sway code
This one replaces our hardcoded contract call script with an actual Sway script. It's a hacky script but we can improve it as Sway allows us to.
This should also get us closer to #216