feat: generalize subscription event parsing#2071
Merged
Conversation
nedsalk
requested review from
Dhaiwat10,
Torres-ssf,
arboleya,
danielbate,
digorithm,
maschad and
petertonysmith94
as code owners
maschad
reviewed
Apr 16, 2024
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
arboleya
previously approved these changes
Apr 16, 2024
Contributor
|
Coverage Report:
Changed Files:
|
petertonysmith94
approved these changes
Apr 16, 2024
maschad
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the event stream parsing logic to properly parse events streamed in multiple chunks and multiple events streamed in one chunk (which was the issue reported in #2053).
closes #2053 and adds infrastructure necessary for #1644