Skip to content

fix: updating incorrect decimal constants#2055

Merged
petertonysmith94 merged 5 commits intomasterfrom
ps/fix/incorrect-decimal-values
Apr 16, 2024
Merged

fix: updating incorrect decimal constants#2055
petertonysmith94 merged 5 commits intomasterfrom
ps/fix/incorrect-decimal-values

Conversation

@petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Apr 15, 2024

Closes #2054


Summary

  • Fixed the decimal values for the following:

    export const DECIMAL_FUEL = 9;
    export const DECIMAL_WEI = 18;
    export const DECIMAL_KWEI = 15;
    export const DECIMAL_MWEI = 12;
    export const DECIMAL_GWEI = 9;
  • Removed the following

    • DECIMAL_ETHER
    • DECIMAL_FINNEY
    • DECIMAL_SZABO

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Apr 15, 2024
@petertonysmith94 petertonysmith94 self-assigned this Apr 15, 2024
@petertonysmith94 petertonysmith94 changed the title chore: updated decimal constants fix: updating incorrect decimal constants Apr 15, 2024
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) April 16, 2024 18:48
@github-actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.41%(-0.01%) 69.74%(+0%) 77.36%(+0%) 79.56%(-0.01%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 124099b into master Apr 16, 2024
@petertonysmith94 petertonysmith94 deleted the ps/fix/incorrect-decimal-values branch April 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect values for DECIMAL constants

4 participants

Comments