-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$hp
is initialised to incorrect value.
#322
Comments
This change would avoid having to offset the value by 1 to use allocated memory, right? |
Yep. Doing an aloc would be just:
...as per the discussion in FuelLabs/sway#1627 |
@Voxelot is there general consensus to go forward with this change? |
There is from the client-team side. @otrho also mentioned that the sway team could make a future-compatible workaround so that this change won't immediately break previously compiled code as well. But this workaround may not be needed if we do the change sooner. |
At VM initialization it says:
It makes more sense for
$hp
to be initialised to justVM_MAX_RAM
. It always essentially points to either non-addressable memory or previously allocated buffers (viaALOC
), both of which are essentially 'reserved'.The text was updated successfully, but these errors were encountered: