Remove Feature Flags from Tx Gossiping#664
Merged
ControlCplusControlV merged 4 commits intocontrolc/p2p_txfrom Oct 2, 2022
Merged
Remove Feature Flags from Tx Gossiping#664ControlCplusControlV merged 4 commits intocontrolc/p2p_txfrom
ControlCplusControlV merged 4 commits intocontrolc/p2p_txfrom
Conversation
Voxelot
approved these changes
Oct 2, 2022
xgreenx
approved these changes
Oct 2, 2022
bvrooman
approved these changes
Oct 2, 2022
bvrooman
pushed a commit
that referenced
this pull request
Oct 6, 2022
* txpool reimpled * Tests go green * clippy * final touches? * clippy fix * clippy maybe? * updated fmt * ci passes? * Error when tx_receiver channel sender is dropped * Updated fmt * Spelling * Update modules channel wiring * Keep alive for incoming_tx_sender * Update features config and tests * Revert unrelated change * test issues now * fixes * fmt * was it that easy? * oops * New testcase for tx gossip * Fmt * Test p2p connection and integ * add tx gossip to default topics * Clean up use statements and dbg * Refactor node_config * Simplify gossip test mod with feature flag * Remove readme changes * Minor cleanup * Minor cleanup * Add all gossip topics to default p2p config * Fix * Clean up txpool cargo * Remove debug statements * Remove Feature Flags from Tx Gossiping (#664) * cleaned up feature flags * fmt * fix leak: * fmt again * Refactor insert_with_broadcast * Remove insert_with_broadcast * Simplify Co-authored-by: controlcthenv <randomlikeabledude@gmail.com> Co-authored-by: ControlCplusControlV <44706811+ControlCplusControlV@users.noreply.github.com> Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the feature flag of p2p from the txpool, and instead just requires a noop
network_senderto be supplied