chore: Reviewed Imports #570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ch1n3du looks like there are still some importing and other compilation errors, let me know if you need help fixing them |
Sorry for not replying sooner, I fell ill but I highlighted the issues I was having at the top of the pr, not really sure how to solve them as they have to do with lifetimes and a proc macro I can't figure out |
|
Thanks for the PR, but as @xgreenx has mentioned we've largely automated this via nightly rustfmt features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been able to format most of the imports but I think I caused a lifetime error in
fuel-coreinfuel-core/src/schema/dap.rsline 445 and 469 and infuel-core/src/schema/message.rsline 17 not really sure how to fix it and would love any help. #537