Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reviewed Imports #570

Closed
wants to merge 3 commits into from
Closed

chore: Reviewed Imports #570

wants to merge 3 commits into from

Conversation

ch1n3du
Copy link

@ch1n3du ch1n3du commented Aug 19, 2022

I've been able to format most of the imports but I think I caused a lifetime error in fuel-core in fuel-core/src/schema/dap.rs line 445 and 469 and in fuel-core/src/schema/message.rs line 17 not really sure how to fix it and would love any help. #537

@ControlCplusControlV
Copy link
Contributor

@ch1n3du looks like there are still some importing and other compilation errors, let me know if you need help fixing them

@ch1n3du
Copy link
Author

ch1n3du commented Aug 23, 2022

@ch1n3du looks like there are still some importing and other compilation errors, let me know if you need help fixing them

Sorry for not replying sooner, I fell ill but I highlighted the issues I was having at the top of the pr, not really sure how to solve them as they have to do with lifetimes and a proc macro I can't figure out

@xgreenx
Copy link
Collaborator

xgreenx commented Sep 13, 2022

Hmm, I think we already did it with new rustfmt rules #575 and #605

@Voxelot
Copy link
Member

Voxelot commented Sep 14, 2022

Thanks for the PR, but as @xgreenx has mentioned we've largely automated this via nightly rustfmt features.

@Voxelot Voxelot closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants