-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add entire team as code owners for the changelog and Cargo.lock
#2655
chore: Add entire team as code owners for the changelog and Cargo.lock
#2655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of we do that I believe we will all be codeowners on all PRs and our approval will count as a code owner approval on the whole code just because the Changelog has been touched. Is it something we want ?
Nope that's not how code owners work. For each file with a code owner touched by a PR, you need an approval from a code owner of that file. This is how it's said in the docs:
Also see this PR: #2598 |
Appreciate the pushback, but the request is based on incorrect assumptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I believe you then, my bad. I just saw that when you look at files changed it says that "@acerone" doesn't exist I believe it should be "@acerone85"
Oh thanks for spotting, fixed now 🙏 |
5e5b214
to
e5d764c
Compare
Because virtually every PR may change these, and anyone in the team should be able to vet changes to these files.