-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with the SDK (MVP cont.) #3
Conversation
Converting to draft until unblocked by new |
Only pushing version change in this PR, will add tests and other features in other more focused PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shameless self-approval :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 0c96dd0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Ahmed Sagdati <[email protected]>
This reverts commit f8541b5.
Appreciate the suggestions a lot, but this PR is more about putting "the basis" in, #11 is about refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions
- The
Command
enum takes 3 fields while the help message lists 4. Should the enum also contain ahelp
field? When themain
function is run it doesn't seem to match forhelp
so I assume some magic happens somewhere and ifhelp
is seen then the program does not continue - Can someone explain to me the purpose of the
uuid
here?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm, give another approve please just want to move forward lol
EDIT(iqdecay): I have taken over this PR, and would like to get this merged "as is", with the refactoring being done in #11 and some more work being done aside.
Continuing the features documented here #2.
This PR integrates the forc wallet plugin with the SDK, adds wallet encryption and storage, wallet
list
ing.Wallet creation now requires a password for the encryption process. Password input is protected and the outputted wallet is outputted in a safe way that can't be stored in the terminal's history.
Wallets are stored in
~/.fuel/wallets
. To open these wallets you need the password you used to create them.Creating the wallet:
Then the safe output: