-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the sign feature #24
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3fb516c
Skeleton added for sign, get_account_from_store() implemented
kayagokalp f4fc137
use DEFAULT_WALLETS_VAULT_PATH if path is not provided while looking …
kayagokalp 6dfcb9c
use derive_account_with_index while signing a transaction
kayagokalp b9e582f
Rebase fix and added sign command doc
kayagokalp 37e76cc
Create the SecretKey instead of Wallet
kayagokalp 59bea91
fmt
kayagokalp 6fa8815
Add plain address to the list
kayagokalp 731d73e
Review suggestions applied.
kayagokalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
use crate::utils::{derive_account_with_index, DEFAULT_WALLETS_VAULT_PATH}; | ||
use anyhow::{anyhow, Result}; | ||
use fuel_crypto::{Message, Signature}; | ||
use fuel_types::Bytes32; | ||
use fuels::prelude::*; | ||
use std::{path::PathBuf, str::FromStr}; | ||
|
||
pub(crate) async fn sign_transaction_manually( | ||
id: &str, | ||
account_index: usize, | ||
path: Option<String>, | ||
) -> Result<(), Error> { | ||
let wallet_path = match &path { | ||
Some(path) => PathBuf::from(path), | ||
None => home::home_dir().unwrap().join(DEFAULT_WALLETS_VAULT_PATH), | ||
}; | ||
let tx_id = Bytes32::from_str(id).map_err(|e| anyhow!("{}", e))?; | ||
let secret_key = derive_account_with_index(&wallet_path, account_index)?; | ||
let message_hash = unsafe { Message::from_bytes_unchecked(*tx_id) }; | ||
let sig = Signature::sign(&secret_key, &message_hash); | ||
println!("Signature: {sig}"); | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should be using an upstream
const
and/or function for constructing this path? E.g. at least awallet_account_derive_path
function or similar. It's probably fine for now, but I've opened an issue to follow-up: #28.