php 8.2 support

[thirsch]

And here is the doctrine1 part of the 8.2 support.

For every missing property, I've tried to keep the style used in the surrounding classes. Some are written "each prop per line", others are separated by comma, as in sf1. My primary goal was to not change too much of existing things but make it compatible to 8.2.

Here is the 8.2 support branch for sf1: FriendsOfSymfony1/symfony1#274

[thirsch]

Method setOption($key, $value) is using dynamic properties:

/**
 * setOption
 *
 * @param string $key
 * @param string $value
 * @return void
 */
public function setOption($key, $value)
{
    $name = 'set' . Doctrine_Inflector::classify($key);

    if (method_exists($this, $name)) {
        $this->$name($value);
    } else {
        $key = '_' . $key;
        $this->$key = $value;
    }
}

[thirsch]

This test might have been wrong for a long time. I created the following example to demonstrate, that without using setOption, this test accidentally created a new public property instead of setting the value in the options array:

<?php

class X {
    private $storage = [];
    
    public function __construct() {
        $this->storage['foo'] = 'bar';
    }
    
    public function __get($name) {
        var_dump('#### magic getter!');
        return $this->storage[$name];
    }
    
    public function getStorage($name) {
        return $this->storage[$name];
    }
}


$x = new X();
var_dump($x->foo);                  // Returns the value of X::$storage['foo']
var_dump($x->getStorage('foo'));    // Returns the value of X::$storage['foo']
$x->foo = "baz";                    // Creates a new dynamic property $foo
var_dump($x->foo);                  // Returns the value of the dynamic property $foo
var_dump($x->getStorage('foo'));    // Returns the value of X::$storage['foo']

[thePanz]

LGTM, not sure why the CI did not run 🤔
Can you rebase this PR @thirsch ?

[thePanz]

Thanks!

• would it be possible to keep the git commit messages consistent? (php 8.2 >)
• Could you please rebase (merged another PR) again?

[thirsch]

Thanks!

• would it be possible to keep the git commit messages consistent? (php 8.2 >)
• Could you please rebase (merged another PR) again?

Sure, commit messages are fixed and branch is rebased.