fix: Database Migration does set current version in DB #98#103
fix: Database Migration does set current version in DB #98#103alquerci wants to merge 12 commits intoFriendsOfSymfony1:masterfrom
Conversation
20059c9 to
a29305f
Compare
da7aca7 to
a657313
Compare
a657313 to
270b6a4
Compare
|
With the patch provided on #131, I release this PR. Sadly, the current CI does not support its execution as missing a MySQL server. Needs to provide a MySQL server linked through socket. |
7827957 to
8cf4b79
Compare
|
To make it easy to configure, I just extracted the DSN configuration from code to environment variable As an example, 2dbee52 environment:
MYSQL_DSN: 'mysql:unix_socket=/var/run/mysqld/mysql.sock;dbname=test;user=root' |
3c0676d to
5d2f9b5
Compare
|
I found how to add MySQL server on GitHub action. Now tests passes. 🟢 |
5d2f9b5 to
5045b52
Compare
| // Migration Tests | ||
| $migration = new GroupTest('Migration Tests', 'migration'); | ||
| $migration->addTestCase(new Doctrine_Migration_TestCase()); | ||
| $migration->addTestCase(new Doctrine_Migration_Mysql_TestCase()); |
There was a problem hiding this comment.
This test is missing in the PR, is it intentional? @alquerci ?
There was a problem hiding this comment.
How is it possible that tests passes?
I will check this mistery in few minutes.
There was a problem hiding this comment.
I understood why.
DoctrineTest::autoload() will auto generate test class if it does not exist.
And all *TestCase.php files are ignored by git, see .gitignore
I rebase and add the not committed file.
Then push.
5e8c299 to
ad4b0f2
Compare
ad4b0f2 to
ac331ed
Compare
|
Rebased onto master to fix conflicts with refacto #138 |
Start with adding tests, someone else can pick it, to provide a fix.
Depends on #90 to run tests.
Tests failed from PHP 8.0.
fixes #98