Fix for ensuring the redirect uri is identical across the initial aut… #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…horization code request and the access token request
netmikey
reviewed
Apr 19, 2017
| ) | ||
| ) { | ||
| // Validate the redirect URI. If a redirect URI has been provided on input, it must be identical | ||
| if ($input["redirect_uri"] && $input["redirect_uri"] === $authCode->getRedirectUri()) { |
There was a problem hiding this comment.
Shouldn't this be !== for "fail if redirect_uri is set and is not equal to the stored one"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…horization code request and the access token request
Fixes - #89