-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializer 0.12 #402
Serializer 0.12 #402
Conversation
} | ||
|
||
$callback = $view->getSerializerCallback(); | ||
if ($callback) { | ||
call_user_func($callback, $this, $serializer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schmittjoh do you think there would be any sense in keeping this callback solution to be able to configure the serializer now that we have the SerializationContext?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the serializer itself is stateless now, I think you can remove this entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok good.
Wouldn't it be easy to keep it BC by offering proxy methods on |
sure .. not sure that i want to maintain BC though .. i do plan to have a 1.0 stable release for 2.3 but until then i am hesitant to maintain BC. |
What command installs jms/serializer-bundle 0.12? I do this and get a sad error:
|
there is no tagged version yet, so did you set the minimum stability to dev? Grayson Koonce [email protected] wrote:
|
uses #382 as a basis
this is will lead to a minor BC break:
Furthermore the default version/groups will now only be applied if no
SerializationContext
was explicitly set.