feat: allow to configure header name for reverse_proxy_ttl specific value

[94noni]

from FriendsOfSymfony/FOSHttpCache#591

Fastly allows to cache via this https://www.fastly.com/documentation/reference/glossary/#term-surrogate-control header Surrogate-Control
(see also https://docs.fastly.com/en/guides/controlling-caching#setting-different-ttls-for-fastly-cache-and-web-browsers)

a specific origin response header, and this bundle allows to define a default value

this PR is allows to configure the ttl header name in the bundle avoid to create a fastly vcl or compute code for example

[dbu]

thanks, this makes sense to have this configurable 👍

can you please

• add a note about this new option to the changelog
• add some tests that ensure changing the header to a non-default name works? in the CacheControlListenerTest unit test and the ConfigurationTest unit test (the later is currently failing because the default value is showing up and not yet expected by the test)
• update headers.rst documentation: add a mention and additional example (i'd keep the existing example and add another one to show how to customize the header) to the reverse_proxy_ttl section

[94noni]

@dbu thanks a lot for your fast review here 👍🏻
comments addressed, please review again and tell me if its all good :)

[dbu]

thanks for the quick reaction. can you document in the reference documentation instead of the features overview? and adjust the ?? fallback please - see comments above?

[dbu]

thanks!

[dbu]

and released: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/3.1.0

[94noni]

wonderful thanks @dbu for your time here !

[richardhj]

In strict mode, this is the error you'll be receiving:

 [KO]
Script importmap:require returned with error code 1
!!  
!!  In FOSHttpCacheExtension.php line 51:
!!                                                  
!!    [ErrorException]                              
!!    Warning: Undefined array key "cache_control"  
!!                                                  
!!  
!!  Exception trace:
!!    at vendor/friendsofsymfony/http-cache-bundle/src/DependencyInjection/FOSHttpCacheExtension.php:51

FOSHttpCacheBundle/src/DependencyInjection/FOSHttpCacheExtension.php

Line 51 in 7b737f7

$ttlHeader = $config['cache_control']['ttl_header'];

[alexander-schranz]

This seems also introduce other issues:

TypeError: FOS\HttpCacheBundle\EventListener\CacheControlListener::__construct(): Argument #2 ($ttlHeader) must be of type string, null given, called in /home/runner/work/sulu/sulu/src/Sulu/Bundle/WebsiteBundle/Tests/Application/var/cache/website/test/ContainerY4qBT6C/Sulu_Bundle_WebsiteBundle_Tests_Application_KernelTestDebugContainer.php on line 530

PHP Warning: Undefined array key "cache_control" in /home/runner/work/sulu/sulu/vendor/friendsofsymfony/http-cache-bundle/src/DependencyInjection/FOSHttpCacheExtension.php on line 51

PHP Warning: Trying to access array offset on value of type null in /home/runner/work/sulu/sulu/vendor/friendsofsymfony/http-cache-bundle/src/DependencyInjection/FOSHttpCacheExtension.php on line 51

[dbu]

fix tagged as 3.1.1 https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/3.1.1

[alexander-schranz]

Thank you all!