Fix tags config #112
Merged
Fix tags config #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "PHP Notice: Undefined index: tag_listener in friendsofsymfony/http-cache-bundle/DependencyInjection/FOSHttpCacheExtension.php on line 73" when ExpressionLanguage is not available.
|
thanks for the fix. well, we could do that. maybe simply have require-dev not list expression language and have all tests that rely on expression language skip if its not available? and then add something to build matrix to additionally test symfony 2.3 with expression language too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "PHP Notice: Undefined index: tag_listener in friendsofsymfony/http-cache-bundle/DependencyInjection/FOSHttpCacheExtension.php
on line 73" when ExpressionLanguage is not available.
A problem here is that we only test on Travis with ExpressionLanguage installed, so we're not able to check all config cases. We may want to add tests where we don’t install ExpressionLanguage to check whether our config is compatible with Symfony LTS 2.3 (from 2.4 onwards ExpressionLanguage ships with Symfony full-stack).