Make tags header configurable #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,6 @@ | |||
| use Symfony\Component\DependencyInjection\Loader\XmlFileLoader; | |||
| use Symfony\Component\DependencyInjection\Reference; | |||
| use Symfony\Component\HttpKernel\DependencyInjection\Extension; | |||
| use Symfony\Component\HttpKernel\Kernel; | |||
There was a problem hiding this comment.
we could run the php-cs-fixer again at some point to eliminate all unused imports.
ddeboer
changed the title
|
i think with the xml config test merged, you will now also need to adjust the xml config example. just restarted travis build to see - we should get a failure now. |
|
added the xml support (and rebased on latest master). this should now build correctly i hope. i am happy with the change, go ahead and merge. its missing the doc however, but i propose to add that in the doc refactoring branch rather than here. |
|
Thanks for the test. I had already added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #73.