-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotation documentation expression language #105
Comments
for the second part, this is true. |
Would it be enough if we pass |
ah, probably yes. though you would need to merge the attributes with request and response, to not pass a nested array. it all happens after routing so the values will be available. or we say to use |
What convention does Symfony follow here? Is there any place they combine ParamConverter with ExpressionLanguage? |
no idea. but i think getting a copy of the attributes array and adding request and response sounds ok to me. |
shall we remove this feature for now, or do you have time to fix it? |
I’m fixing it as we speak. |
Wait, we’re already doing this for the Tag annotation. @dbu So can we close this? Or should something be changed here too? |
hm, i think it does not hurt to also support them in the configured tagging too, not only in annotations. chances are a configuration matches several requests, but that is up to the user to think about what he is doing. i see the documentation is already fixed. |
i fear that the expression language example in the annotation doc are wrong. the TagSubscriber only passes in request and response, but not the parameters to the method that was called. if we can manage to provide the named parameters, that would be awesome. otherwise we should change the examples to use the request object.
i also got the impression that
* @Tag(expression="'news-'~article.id")
mentioned inhttp://foshttpcachebundle.readthedocs.org/en/latest/tagging.html#invalidate-tags will not work. for me, expression language did not behave like twig, i had to write article.getId().
The text was updated successfully, but these errors were encountered: