Add notice support in ParameterHandler for consistency - #392
Conversation
|
Moin WalkthroughDie Änderung erweitert den Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 Minuten Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds support for the 'notice' parameter in MFormParameterHandler, enabling developers to pass 'notice' in parameter arrays alongside 'label' and 'full'. This fills a consistency gap where 'notice' was only supported in the attributes array but not in the parameters array.
Changes:
- Added 'notice' case to MFormParameterHandler switch statement to call setNotice($value)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Vielen Dank für diesen PR und das schnelle Erkennen der fehlenden Lücke! 🙏 Wir haben die Änderung in einem eigenen Branch aufgegriffen und zusammen mit der vollständigen Erläuterung aus Issue #389 in PR #394 übernommen. Dort haben wir auch den Kontext der gesamten Bitte schau dir gerne #394 an – wir schließen diesen PR daher zugunsten des neuen. Nochmals danke für den Beitrag! 🎉 |
Problem
labelandfullwork in the parameter array (e.g., for addMediaField), butnoticedoes not.Solution
Added
noticecase to MFormParameterHandler, same aslabelandfull.Example
This now works: