-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split up into multiple files and clarify examples #324
Conversation
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 94.13% 94.13%
Complexity 224 224
=========================================
Files 19 19
Lines 580 580
=========================================
Hits 546 546
Misses 34 34 Help us with your feedback. Take ten seconds to tell us how you rate us. |
This sounds like I used on #249 $manager->value('category_id', [
'multiValue' => true,
'multiValueSeparator' => ',',
'field' => ['Categories.id'],
'beforeProcess' => function (Query $query, array $args, $filter) {
$query->innerJoinWith('Categories');
},
]); so in the URL you can pass |
Indeed this does work as well. |
My code is combining two filter config in the docs beforeProcess and Value Filter The code serves as an example of the value filter. |
I didn't mean that I don't understand your example 😉 Since the docs/README.md is already quite big I wouldn't mind splitting it up into several pages, so something like
|
I agree it would be better to show examples, or repeat titles/sections like it's done on the crud plugin documentation |
All the options on themselves can be quite overwhelming, so a restructuring of the docs would be quite nice I think, dedicated sections for all filters, each with an example would be very helpful especially for new users. |
Co-authored-by: Oliver Nowak <[email protected]>
Co-authored-by: Oliver Nowak <[email protected]>
Co-authored-by: Oliver Nowak <[email protected]>
This is my first version of the split up doc including the more simpler, explicit filter examples: |
So are there any other objections if my approach of splitting up the docs is good/bad? |
docs/filters-and-examples.md
Outdated
---------- | ||
|
||
`Value` to limit results to exact matches | ||
<details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The details are collapsed by default and I don't like the fact that an additional click is required to view the code e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since most of these code snippets are only one liners I can actually remove that collapsible element.
Relates to #323 and #136