Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not filter for value instead of long array list. #304

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Nov 20, 2020

The multiValue part is nice, but once you have too many values, the URL gets out of hand.

?functional_type=0,1,2,8,10,3,7,5,4,6,11,...........&...

For this I propose the "not" config instead.
Works fine for us locally.

?functional_type=!9&...

Does this sound good?

Fully BC.

Constraints: This is disabled to work together with multiValue as it is designed as alternative config.
If someone has ideas how to combine them, that could be a future PR maybe?

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #304 (ffa7c85) into master (ee0b26f) will decrease coverage by 0.06%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #304      +/-   ##
============================================
- Coverage     93.38%   93.32%   -0.07%     
- Complexity      227      231       +4     
============================================
  Files            18       18              
  Lines           590      599       +9     
============================================
+ Hits            551      559       +8     
- Misses           39       40       +1     
Impacted Files Coverage Δ Complexity Δ
src/Model/Filter/Value.php 96.55% <88.88%> (-3.45%) 12.00 <0.00> (+4.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0b26f...ffa7c85. Read the comment docs.

docs/README.md Outdated Show resolved Hide resolved
src/Model/Filter/Value.php Outdated Show resolved Hide resolved
src/Model/Filter/Value.php Outdated Show resolved Hide resolved
@ADmad ADmad merged commit 55cad97 into master Nov 20, 2020
@ADmad ADmad deleted the not-value branch November 20, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants