Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] feat: TableKey takes into account the class name #29

Conversation

krugerman007
Copy link
Contributor

@krugerman007 krugerman007 commented Aug 9, 2024

Same as #28, but for 1.x version.

--

We have the problem that you cannot load 2 fixtures for one table one after the other. For example:

  • we load a fixture with 2 rows (Students\UsersFixture),
  • the table with 2 rows has not been changed,
  • we load a fixture for the same table but with 5 rows (Teachers\UsersFixture).

The last fixture is not applied because the hash was not changed. And the plugin only checks the hash of the table by connection and table name. The plugin does not take into account the class name of fixtures.

@ravage84 ravage84 changed the title feat: TableKey takes into account the class name [1.x] feat: TableKey takes into account the class name Aug 9, 2024
@ravage84 ravage84 added this to the 1.x milestone Aug 9, 2024
@ravage84
Copy link
Collaborator

ravage84 commented Aug 9, 2024

@krugerman007 could you please show two examples of such hashes?

  • One with a regularly named fixture file
  • One with a blank or irregularly named fixture file

May be a var_export()/debug() outputs or screenshots of the variable while debugging.

@ravage84 ravage84 self-assigned this Aug 9, 2024
@krugerman007
Copy link
Contributor Author

krugerman007 commented Aug 9, 2024

@krugerman007 could you please show two examples of such hashes?

  • One with a regularly named fixture file
  • One with a blank or irregularly named fixture file

May be a var_export()/debug() outputs or screenshots of the variable while debugging.

Sure:

2024-08-09 11_11_22

I have also started our tests with this fix: it works now very fast: 2 times faster! From 5 min 39 sec to 3 min 32 sec loca :)

2024-08-09 12_10_51

@ravage84 ravage84 merged commit 7ba14c8 into FriendsOfCake:1.x Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants