CakePHP 4.x compatibility #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
swiffer
commented
Dec 28, 2019
swiffer
commented
- code style
- type hints
ADmad
reviewed
Dec 28, 2019
|
@ADmad I've added compatibility for Postgres as well (https://stackoverflow.com/a/13948327). Can you take a look please? |
|
I don't have enough knowledge regarding Postgres to be able to review that. Hopefully someone else can. |
|
I've tested the Statement locally, worked fine here |
revert add support for postgres. this does not work when a table changes that has foreign key constraints.
|
@ADmad I had to revert the changes for postgres because it does not work when foreign key constraints exists. this is CakePHP 4.0 compatibility only now. |
jippi
reviewed
Dec 29, 2019
jippi
requested changes
Dec 29, 2019
|
@jippi can you take a look again so we can get this merged ? |
|
What is still needed for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.