[multisite] Improve retrieval of individual‑site info in a multisite … #802
Conversation
fajardoleo
force-pushed
the
feature/leo/multisite-site-info-enhancements
branch
3 times, most recently
from
e62f937 to
2f18daa
Compare
includes/class-fs-hook-snapshot.php
Outdated
| public function remove( $hook ) { | ||
| global $wp_filter; | ||
|
|
||
| if ( isset( $wp_filter[ $hook ] ) ) { |
There was a problem hiding this comment.
In normal WP context this is good enough, but in edge cases it could be useful to safe check the existence of $wp_filter:
if ( isset( $wp_filter ) && isset( $wp_filter[ $hook ] ) ) {
This makes the code more robust in edge cases, such as when the file is loaded outside of the standard WordPress environment or during automated tests.
In normal WordPress usage, this is rarely necessary, but it helps prevent potential errors in atypical scenarios.
DanieleAlessandra
left a comment
DanieleAlessandra
left a comment
There was a problem hiding this comment.
The changes look good enough to me, only read the one comment and think about it (we have to deal with tons of different use cases).
fajardoleo
force-pushed
the
feature/leo/multisite-site-info-enhancements
branch
from
2f18daa to
99d55b6
Compare
swashata
left a comment
swashata
left a comment
There was a problem hiding this comment.
Please see my only question
includes/class-freemius.php
Outdated
| } | ||
| } | ||
|
|
||
| $current_blog_id = get_current_blog_id(); |
There was a problem hiding this comment.
I am not fully aware of the mechanism, but don't we want to call this before even switching on line 7854?
| $info[ 'registration_date' ] = $registration_date; | ||
| } | ||
|
|
||
| if ( $switched ) { |
There was a problem hiding this comment.
@fajardoleo why are we removing this? Don't we want to restore the blog like before?
…ure/swas/restore_blog_fix_alt_exploration` branch.
fajardoleo
force-pushed
the
feature/leo/multisite-site-info-enhancements
branch
from
99d55b6 to
a8e7e4b
Compare
…network.