Skip to content

[wordpress-compliance] Fix the loading/enqueueing of JS scripts in WP. #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[wordpress-compliance] Fix the loading/enqueueing of JS scripts in WP. #687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e0c00e
[wordpress-compliance] Add the expected argument for the loading of s…
bahiirwa Feb 11, 2024
6791f4c
[refactor] Evaluate all to true to avoid breaking changes.
bahiirwa Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/fs-core-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function fs_enqueue_local_style( $handle, $path, $deps = array(), $ver = false,
}

if ( ! function_exists( 'fs_enqueue_local_script' ) ) {
function fs_enqueue_local_script( $handle, $path, $deps = array(), $ver = false, $in_footer = 'all' ) {
function fs_enqueue_local_script( $handle, $path, $deps = array(), $ver = false, $in_footer = true ) {
wp_enqueue_script( $handle, fs_asset_url( WP_FS__DIR_JS . '/' . trim( $path, '/' ) ), $deps, $ver, $in_footer );
}
}
Expand Down Expand Up @@ -1502,4 +1502,4 @@ function fs_apply_filter( $module_unique_affix, $tag, $value ) {
function fs_get_optional_constant( $constant_name, $default_value = null ) {
return defined( $constant_name ) ? constant( $constant_name ) : $default_value;
}
}
}