Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to remove "RT_TRACE" because it is obsolete and has security problems #159

Closed
Ygor6889 opened this issue Jul 16, 2022 · 4 comments · Fixed by #160
Closed

Suggestion to remove "RT_TRACE" because it is obsolete and has security problems #159

Ygor6889 opened this issue Jul 16, 2022 · 4 comments · Fixed by #160

Comments

@Ygor6889
Copy link

I suggest the creator of this driver remove everything related to "RT_TRACE" because this line is unnecessary and does nothing except give problems compiling the driver, this line is no longer needed because newer kernels don't need it anymore

@FreedomBen
Copy link
Owner

Thanks @Ygor6889 !

@trumad
Copy link

trumad commented Sep 25, 2022

I just ran into a build failure because of this. Not quite sure how to fix it, but I'll try removing all "traces" of RT_TRACE

@trumad
Copy link

trumad commented Sep 25, 2022

Hooray, that worked. I ran the script from scratch, waited until the file rtl8188ee/pwrseqcmd.c existed, removed every call to RT_TRACE from it, and the script continued without issue. Unfortunately my wifi card still stops working intermittently, but that's a separate issue.

@J0w03L
Copy link
Contributor

J0w03L commented Oct 12, 2022

Hooray, that worked. I ran the script from scratch, waited until the file rtl8188ee/pwrseqcmd.c existed, removed every call to RT_TRACE from it, and the script continued without issue. Unfortunately my wifi card still stops working intermittently, but that's a separate issue.

Ran into the same problem and this worked for me too; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants