Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install failed in ubuntu18.04 #134

Open
nevsayno opened this issue Jan 5, 2019 · 3 comments
Open

install failed in ubuntu18.04 #134

nevsayno opened this issue Jan 5, 2019 · 3 comments

Comments

@nevsayno
Copy link

nevsayno commented Jan 5, 2019

use branch ubuntu-18.04,
there are no errors reported at install stage, but when test new module, it appears:

[] Not running the new rtlwifi (running stock driver)
[
] Not running the new rtl8192c_common (running stock driver)
[*] Not running the new rtl8192ce (running stock driver)

after dig into the source code, bug fixed with the following change:

diff --git a/Makefile b/Makefile
index 54ae3a9..4b909c2 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
 CC = gcc
 KVER  := $(shell uname -r)
 KSRC := /lib/modules/$(KVER)/build
-MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/rtlwifi
+MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless/realtek/rtlwifi
 FIRMWAREDIR := /lib/firmware/
 PWD := $(shell pwd)
 CLR_MODULE_FILES := *.mod.c *.mod *.o .*.cmd *.ko *~ .tmp_versions* modules.order Module.symvers
diff --git a/functions.sh b/functions.sh
index 718fe9e..88f260b 100644
--- a/functions.sh
+++ b/functions.sh
@@ -352,7 +352,7 @@ runningStockRtl8821ae ()
     runningAnyRtl8821ae && ! runningOurRtl8821ae
 }
 
-readonly rtlwifi_orig="/lib/modules/$(uname -r)/kernel/drivers/net/wireless/rtlwifi"
+readonly rtlwifi_orig="/lib/modules/$(uname -r)/kernel/drivers/net/wireless/realtek/rtlwifi"
 readonly rtlwifi_backup_dir="$HOME/.rtlwifi-backup"
 readonly rtlwifi_backup_outfile="$rtlwifi_backup_dir/$(uname -r).tar.gz"
 
@@ -387,7 +387,7 @@ backupCurrent ()
             mkdir -p "$rtlwifi_backup_dir"
             tar -czf "$rtlwifi_backup_outfile" -C "$rtlwifi_orig" . > /dev/null 2>&1
         else
-            echo "Could not backup rtlwifi because it could not be found!  Expected at $rtlwifi_orig" >&2
+            echo "Could not backup rtlwifi because it could not be found!  Expected at $rtlwifi_orig"
         fi
     fi
 }
@kkursor
Copy link

kkursor commented Sep 16, 2019

Confirm this on latest revision. Had to patch makefiles by hand.

@FreedomBen
Copy link
Owner

FreedomBen commented Oct 1, 2019

Hey guys, really sorry for the delay.

I couldn't test the patch but I went ahead and pushed it for the ubuntu-18.04 branch. Can somebody pull latest and test it?

@nevsayno thanks for providing the diff.

@unti1x
Copy link

unti1x commented Oct 16, 2019

Builds and installs successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants